From: Jonathan Corbet <corbet@lwn.net>
To: Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
ldv-project@linuxtesting.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup()
Date: Sat, 4 Apr 2015 15:36:47 +0200 [thread overview]
Message-ID: <20150404153647.01d475a5@lwn.net> (raw)
In-Reply-To: <1428106561-12623-1-git-send-email-khoroshilov@ispras.ru>
On Sat, 4 Apr 2015 03:16:01 +0300
Alexey Khoroshilov <khoroshilov@ispras.ru> wrote:
> If i2c_add_adapter() fails, adap is not deallocated.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Actually, the worse thing is that it leaves the IRQ enabled...it's good
you moved that lines down. Even better, of course, that the failure path
has probably never been run during the life of this driver...:)
Should there be some sort of proper reported-by line for the driver
verification project?
Acked-by: Jonathan Corbet <corbet@lwn.net>
jon
next prev parent reply other threads:[~2015-04-04 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 0:16 [PATCH] [media] marvell-ccic: fix memory leak on failure path in cafe_smbus_setup() Alexey Khoroshilov
2015-04-04 13:36 ` Jonathan Corbet [this message]
2015-04-04 16:59 ` Alexey Khoroshilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150404153647.01d475a5@lwn.net \
--to=corbet@lwn.net \
--cc=khoroshilov@ispras.ru \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox