From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: emxx_udc: test returned value
Date: Sat, 4 Apr 2015 20:12:43 +0300 [thread overview]
Message-ID: <20150404171243.GY10964@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.02.1504041818180.2075@localhost6.localdomain6>
On Sat, Apr 04, 2015 at 06:20:53PM +0200, Julia Lawall wrote:
> Couldn't one say:
>
> x = NULL;
> y = &x->whatever;
> z = container_of(y, struct blah, whatever);
>
> and end up with z being NULL?
That is crazy person code. It looks deliberately wrong. If we start
merging deliberate mistakes then we're already screwed.
I have a smatch check which warns on container_of() but I should update
it to not complain if it's the first struct member. I have looked at
quite a few of these warnings and I worry that there are some places
where it relies on container_of() to be a no-op... That's also crazy
but it's the kind of crazy that people do in real life. :P
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-04 17:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 14:59 [PATCH 0/2] test returned value Julia Lawall
2015-04-04 14:59 ` [PATCH 1/2] clk: versatile: " Julia Lawall
2015-04-08 18:25 ` Stephen Boyd
2015-04-09 7:30 ` Linus Walleij
2015-04-09 15:23 ` Stephen Boyd
2015-04-04 14:59 ` [PATCH 2/2] staging: emxx_udc: " Julia Lawall
2015-04-04 15:59 ` Dan Carpenter
2015-04-04 16:07 ` Greg Kroah-Hartman
2015-04-04 16:07 ` Greg Kroah-Hartman
2015-04-04 16:20 ` Julia Lawall
2015-04-04 16:54 ` Greg Kroah-Hartman
2015-04-04 17:12 ` Dan Carpenter [this message]
2015-04-04 17:21 ` Julia Lawall
2015-04-04 17:31 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150404171243.GY10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox