From: Nicholas Mc Guire <der.herr@hofr.at>
To: Rob Clark <robdclark@gmail.com>
Cc: Nicholas Mc Guire <hofrat@osadl.org>,
David Airlie <airlied@linux.ie>, Hai Li <hali@codeaurora.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/msm: fix build warning - missing prototype
Date: Sun, 5 Apr 2015 05:37:22 +0200 [thread overview]
Message-ID: <20150405033722.GA9842@opentech.at> (raw)
In-Reply-To: <CAF6AEGs=6_ByXxcEtte-3W3dk9AmhDdbQvt70kZxJ0vBukKmew@mail.gmail.com>
On Sat, 04 Apr 2015, Rob Clark wrote:
> On Fri, Apr 3, 2015 at 10:39 PM, Nicholas Mc Guire <hofrat@osadl.org> wrote:
> > fix build warning when building edp/edp_aux.o due to missing
> > prototype for edp_aux_transfer.
> >
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > ---
> > building drivers/gpu/drm/msm/msm.ko gives the following warning:
> > drivers/gpu/drm/msm/edp/edp_aux.c:118:9: warning: no previous prototype for 'edp_aux_transfer' [-Wmissing-prototypes]
> > ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg)
> > ^
> >
>
> thx.. fwiw, looks like edp_aux_transfer is only used in that one
> file.. so probably it actually wants to be static instead..
>
yup - missed that - making it static is the cleaner solution
will resend.
thx!
hofrat
prev parent reply other threads:[~2015-04-05 3:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-04 2:39 [PATCH] drm/msm: fix build warning - missing prototype Nicholas Mc Guire
2015-04-04 14:01 ` Rob Clark
2015-04-05 3:37 ` Nicholas Mc Guire [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150405033722.GA9842@opentech.at \
--to=der.herr@hofr.at \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hali@codeaurora.org \
--cc=hofrat@osadl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox