From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751356AbbDEFFs (ORCPT <rfc822;w@1wt.eu>);
	Sun, 5 Apr 2015 01:05:48 -0400
Received: from mail-wg0-f50.google.com ([74.125.82.50]:36731 "EHLO
	mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750727AbbDEFFm (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 5 Apr 2015 01:05:42 -0400
Date: Sun, 5 Apr 2015 07:05:37 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Chris Metcalf <cmetcalf@ezchip.com>
Cc: Rik van Riel <riel@redhat.com>, Mike Galbraith <umgwanakikbuti@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] nohz: make nohz_full imply isolcpus
Message-ID: <20150405050537.GA26390@gmail.com>
References: <1428078248-5425-1-git-send-email-cmetcalf@ezchip.com>
 <1428078248-5425-2-git-send-email-cmetcalf@ezchip.com>
 <20150403174258.GC13598@lerouge>
 <551EE7F4.6070406@ezchip.com>
 <551FF0B9.4010907@redhat.com>
 <55201AC4.8000201@ezchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55201AC4.8000201@ezchip.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Chris Metcalf <cmetcalf@ezchip.com> wrote:

> On 4/4/2015 10:10 AM, Rik van Riel wrote:
> >>Rik, what's the change you're proposing that's similar to this one? Thanks!
> >I don't have this particular one, and I like it.
> >
> >I know there are use cases where isolcpus= without
> >nohz_full= makes sense, but I cannot think of the
> >reverse.
> >
> >Acked-by: Rik van Riel<riel@redhat.com>
> 
> Thanks, I'll push it via the tile tree unless someone would prefer otherwise.

Yes, I'd prefer otherwise: please send the final, agreed upon patch to 
the timer tree.

> (The tick_nohz_full_set_cpus() and tick_nohz_full_clear_cpus() 
> routines are in earlier tile tree commits, the latter supporting a 
> change to the tile network driver.)

This is absolutely not OK, please push this through the timer tree. We 
don't do generic timer changes through architecture trees.

Thanks,

	Ingo