Re: Unreliable hibernation on Lenovo x230 (regression)

Ingo Molnar
2015-04-06T07:12:44Z

* Yinghai Lu <yinghai@kernel.org> wrote:

> On Sun, Apr 5, 2015 at 12:24 AM, joeyli <jlee@suse.com> wrote:
> >> >
> >>
> >> I took the commit 8f778bbc542ddf8f6243b21d6aca087e709cabdc as the base for further checking (I started building before I read your message). It's a descendant of 4.0-rc6, so I hope it's not going to make a difference.
> >>
> >> Results:
> >> 8f778bb : bad
> >> 8f778bb + reverted 84c91b7 : good
> >> 8f778bb + patch [1] : good
> >
> > Thanks for your dmesg on bko#96111.
> > I checked and confirm there have the situation of setup_data reserved as E820_RESERVED_KERN.
> > I will add comment on bugzilla.
> >
> >>
> >> Thanks!
> >>
> >> [1]:
> >> x86: Kill E820_RESERVED_KERN https://lkml.org/lkml/2015/3/4/434 as suggested in joeyli's other email.
> >
> > I think just revert 84c91b7ae until Yinghai Lu's patches merged to v4.1.
> > I will resend 84c91b7ae patch until Yinghai Lu's patches merged.
>
> Can you please put https://lkml.org/lkml/2015/3/4/434
> into tip?

I cannot apply this patch without a readable changelog, see:

http://lkml.iu.edu/hypermail/linux/kernel/1503.1/05342.html

Your changelog (again) violates about half of the principles I tried
to outline in that post.

Thanks,

Ingo