[PATCH] MAINTAINERS: Add me on list of Dell laptop drivers

[PATCH] MAINTAINERS: Add me on list of Dell laptop drivers

[Pali Rohár]

Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
---
 MAINTAINERS |    7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 88c09ca..72a08ef 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3058,10 +3058,16 @@ F:	drivers/net/fddi/defxx.*
 
 DELL LAPTOP DRIVER
 M:	Matthew Garrett <mjg59@srcf.ucam.org>
+M:	Pali Rohár <pali.rohar@gmail.com>
 L:	platform-driver-x86@vger.kernel.org
 S:	Maintained
 F:	drivers/platform/x86/dell-laptop.c
 
+DELL LAPTOP FREEFALL DRIVER
+M:	Pali Rohár <pali.rohar@gmail.com>
+S:	Maintained
+F:	drivers/platform/x86/dell-smo8800.c
+
 DELL LAPTOP SMM DRIVER
 M:	Guenter Roeck <linux@roeck-us.net>
 S:	Maintained
@@ -3076,6 +3082,7 @@ F:	drivers/firmware/dcdbas.*
 
 DELL WMI EXTRAS DRIVER
 M:	Matthew Garrett <mjg59@srcf.ucam.org>
+M:	Pali Rohár <pali.rohar@gmail.com>
 S:	Maintained
 F:	drivers/platform/x86/dell-wmi.c
 
-- 
1.7.9.5

Re: [PATCH] MAINTAINERS: Add me on list of Dell laptop drivers

[Darren Hart]

On Sun, Mar 29, 2015 at 03:38:50PM +0200, Pali Rohár wrote:

Please include why. No empty commit messages please.

For example, you've written nearly a third of the dell-wmi.c driver, and all the
dell-smo8800.c driver.

Dell Laptop is still pending the keyboard backlight patches though I believe
(have I missed them?), so you don't currently have code ownership there. I agree
you should be on the MAINTAINERS list, but it would be good to get your keyboard
backlight changes in first.

Gosh... sure seems like we should have merged that already... am I missing
something? The last thing I see in master, testing, and next is the revert from
Jan 21....

Also, Matthew, you're the listed maintainer for these, do you agree to adding
Pali?

> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
>  MAINTAINERS |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 88c09ca..72a08ef 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3058,10 +3058,16 @@ F:	drivers/net/fddi/defxx.*
>  
>  DELL LAPTOP DRIVER
>  M:	Matthew Garrett <mjg59@srcf.ucam.org>
> +M:	Pali Rohár <pali.rohar@gmail.com>
>  L:	platform-driver-x86@vger.kernel.org
>  S:	Maintained
>  F:	drivers/platform/x86/dell-laptop.c
>  
> +DELL LAPTOP FREEFALL DRIVER
> +M:	Pali Rohár <pali.rohar@gmail.com>
> +S:	Maintained
> +F:	drivers/platform/x86/dell-smo8800.c
> +
>  DELL LAPTOP SMM DRIVER
>  M:	Guenter Roeck <linux@roeck-us.net>
>  S:	Maintained
> @@ -3076,6 +3082,7 @@ F:	drivers/firmware/dcdbas.*
>  
>  DELL WMI EXTRAS DRIVER
>  M:	Matthew Garrett <mjg59@srcf.ucam.org>
> +M:	Pali Rohár <pali.rohar@gmail.com>
>  S:	Maintained
>  F:	drivers/platform/x86/dell-wmi.c
>  
> -- 
> 1.7.9.5
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] MAINTAINERS: Add me on list of Dell laptop drivers

[Pali Rohár]

[-- Attachment #1: Type: Text/Plain, Size: 2446 bytes --]

On Thursday 02 April 2015 07:10:27 Darren Hart wrote:
> On Sun, Mar 29, 2015 at 03:38:50PM +0200, Pali Rohár wrote:
> 
> Please include why. No empty commit messages please.
> 
> For example, you've written nearly a third of the dell-wmi.c
> driver, and all the dell-smo8800.c driver.
> 

Ok. If you need description include this:

===
MAINTAINERS: Add me on list of Dell laptop drivers

I have written more parts of dell laptop drivers dell-laptop.c, 
dell-wmi.c and dell-smo8800.c
===

> Dell Laptop is still pending the keyboard backlight patches
> though I believe (have I missed them?), so you don't
> currently have code ownership there. I agree you should be on
> the MAINTAINERS list, but it would be good to get your
> keyboard backlight changes in first.
> 

ok.

> Gosh... sure seems like we should have merged that already...
> am I missing something? The last thing I see in master,
> testing, and next is the revert from Jan 21....
> 

backlight support was merged for 3.19, but has small problem with 
ALS settings. And then you decided to revert it for 3.19. After 
that problem was fixed and last (2015-03-06) you wrote that you 
queued patch again for 4.1 release.

> Also, Matthew, you're the listed maintainer for these, do you
> agree to adding Pali?
> 
> > Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > ---
> > 
> >  MAINTAINERS |    7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 88c09ca..72a08ef 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -3058,10 +3058,16 @@ F:	drivers/net/fddi/defxx.*
> > 
> >  DELL LAPTOP DRIVER
> >  M:	Matthew Garrett <mjg59@srcf.ucam.org>
> > 
> > +M:	Pali Rohár <pali.rohar@gmail.com>
> > 
> >  L:	platform-driver-x86@vger.kernel.org
> >  S:	Maintained
> >  F:	drivers/platform/x86/dell-laptop.c
> > 
> > +DELL LAPTOP FREEFALL DRIVER
> > +M:	Pali Rohár <pali.rohar@gmail.com>
> > +S:	Maintained
> > +F:	drivers/platform/x86/dell-smo8800.c
> > +
> > 
> >  DELL LAPTOP SMM DRIVER
> >  M:	Guenter Roeck <linux@roeck-us.net>
> >  S:	Maintained
> > 
> > @@ -3076,6 +3082,7 @@ F:	drivers/firmware/dcdbas.*
> > 
> >  DELL WMI EXTRAS DRIVER
> >  M:	Matthew Garrett <mjg59@srcf.ucam.org>
> > 
> > +M:	Pali Rohár <pali.rohar@gmail.com>
> > 
> >  S:	Maintained
> >  F:	drivers/platform/x86/dell-wmi.c

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [PATCH] MAINTAINERS: Add me on list of Dell laptop drivers

[Darren Hart]

On Sun, Apr 05, 2015 at 11:11:49PM +0200, Pali Rohár wrote:
> On Thursday 02 April 2015 07:10:27 Darren Hart wrote:
> > On Sun, Mar 29, 2015 at 03:38:50PM +0200, Pali Rohár wrote:
> > 
> > Please include why. No empty commit messages please.
> > 
> > For example, you've written nearly a third of the dell-wmi.c
> > driver, and all the dell-smo8800.c driver.
> > 
> 
> Ok. If you need description include this:
> 
> ===
> MAINTAINERS: Add me on list of Dell laptop drivers
> 
> I have written more parts of dell laptop drivers dell-laptop.c, 
> dell-wmi.c and dell-smo8800.c
> ===
> 
> > Dell Laptop is still pending the keyboard backlight patches
> > though I believe (have I missed them?), so you don't
> > currently have code ownership there. I agree you should be on
> > the MAINTAINERS list, but it would be good to get your
> > keyboard backlight changes in first.
> > 
> 
> ok.
> 
> > Gosh... sure seems like we should have merged that already...
> > am I missing something? The last thing I see in master,
> > testing, and next is the revert from Jan 21....
> > 
> 
> backlight support was merged for 3.19, but has small problem with 
> ALS settings. And then you decided to revert it for 3.19. After 
> that problem was fixed and last (2015-03-06) you wrote that you 
> queued patch again for 4.1 release.

Right you are, and I appear to have dropped that ball. Found it, and it's now in
my testing branch, and will run through the 0day testing, then into my next
tomorrow, still on track for 4.1.

> 
> > Also, Matthew, you're the listed maintainer for these, do you
> > agree to adding Pali?

I'm accepted silence as acceptance :-)

-- 
Darren Hart
Intel Open Source Technology Center