From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbbDEXxu (ORCPT ); Sun, 5 Apr 2015 19:53:50 -0400 Received: from mail-ig0-f180.google.com ([209.85.213.180]:32805 "EHLO mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752590AbbDEXxs (ORCPT ); Sun, 5 Apr 2015 19:53:48 -0400 Date: Sun, 5 Apr 2015 16:53:43 -0700 From: Dmitry Torokhov To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Andrew Morton , Matthew Garrett , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: atkbd: Fix release quirk for Dell models Message-ID: <20150405235343.GA5313@dtor-ws> References: <1427639779-27377-1-git-send-email-pali.rohar@gmail.com> <20150405214833.GD31564@dtor-ws> <201504060000.32145@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <201504060000.32145@pali> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 06, 2015 at 12:00:32AM +0200, Pali Rohár wrote: > On Sunday 05 April 2015 23:48:33 Dmitry Torokhov wrote: > > Hi Pali, > > > > On Sun, Mar 29, 2015 at 04:36:19PM +0200, Pali Rohár wrote: > > > This patch fixes commit 61579ba83934 ("Input: atkbd - expand > > > Latitude's force release quirk to other Dells"). Before > > > that commit release quirks were called for all Dell > > > Latitude models. After that commit only for Portable Dell > > > devices. But lot of Latitude models are Laptop or Notebook > > > DMI devices so quirks are not called. > > > > > > Release quirks are still needed also for new Dell Latitude > > > models, so this patch enables quirks for all Portable, > > > Laptop, Notebook and Sub-Notebook Dell devices. > > > > Does Dell use all these types for their laptops? What models > > do you know that need this quirk? > > > > Thanks. > > > > I do not if Dell use all types, but months ago Matthew wrote to > include also other numbers not only 9 (Laptop) and you agreed. Hmm, I tried looking back but I could not quite find the discussion. > > I do not know exact list of models which needs these quirks, but > before that commit (61579ba83934) it was used for all Latitude > models. At least I see that switches do not generate release > events and on older Latitude machines some Fn keys do not > generate them too. So the question is still: what models do need this quirk and what chassis type they are used. Regardless, I have not accepted quirks for force_release and atkbd keymaps for many years now as the task to adjust both keymap and force_release list has been offloaded to udev. Thanks. -- Dmitry