From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephan Mueller <smueller@chronox.de>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] crypto: remove instance when test failed
Date: Mon, 6 Apr 2015 12:45:03 +0800 [thread overview]
Message-ID: <20150406044503.GA6331@gondor.apana.org.au> (raw)
In-Reply-To: <12421064.DcDv9fIrjP@tachyon.chronox.de>
On Fri, Apr 03, 2015 at 09:29:44PM +0200, Stephan Mueller wrote:
>
> What about moving the current crypto_unregister_instance into
> __crypto_unregister_instance and creating a new crypto_unregister_instance
> that takes the ref count and once it got it, it calls
> __crypto_unregister_instance. If it did not get the ref count, it simply
> returns because the inst apparently was already removed.
>
> Only the crypto_unregister_instance is EXPORT_SYMBOL whereas the
> __crypto_unregister_instance is static.
That's not going to work because you need to grab the reference
count before you release the mutex. Let me fix up crypto_user first
and then you can use it for your case too (or at least borrow the
idea).
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2015-04-06 4:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 17:05 [PATCH v2] crypto: remove instance when test failed Stephan Mueller
2015-04-03 9:58 ` Herbert Xu
2015-04-03 15:17 ` Stephan Mueller
2015-04-03 15:52 ` Herbert Xu
2015-04-03 19:29 ` Stephan Mueller
2015-04-06 4:45 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406044503.GA6331@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox