Re: [PATCH v6] x86: mce: kexec: switch MCE handler for kexec/kdump

Naoya Horiguchi
2015-03-06T09:35:36Z

On Fri, Mar 06, 2015 at 10:27:38AM +0100, Borislav Petkov wrote:
> On Fri, Mar 06, 2015 at 09:09:30AM +0000, Naoya Horiguchi wrote:
> > I'm not sure why that works, could you elabroate it?
>
> Because the _safe() variants are only for handling reads to possibly
> non-existent MSRs. The _STATUS MSRs which you're accessing are
> guaranteed to be present, otherwise __mcheck_cpu_cap_init() would've
> disabled MCA on the first kernel, thus the mca_cfg.disabled check.

Great, thanks.

> We can always switch to the _safe() variants later if really needed - I
> just don't see the need for them right now.

OK, I'll do with rdmsrl().

Thanks,
Naoya Horiguchi