From: Mark Brown <broonie@kernel.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@sonymobile.com>,
Andy Gross <agross@codeaurora.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Lee Jones <lee.jones@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] Refactor Qualcomm RPM regulator to single platform_device
Date: Mon, 6 Apr 2015 17:51:54 +0100 [thread overview]
Message-ID: <20150406165154.GP6023@sirena.org.uk> (raw)
In-Reply-To: <551DC94C.3060001@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Thu, Apr 02, 2015 at 03:57:16PM -0700, Stephen Boyd wrote:
> On 04/02/15 15:26, Mark Brown wrote:
> > Guenther sent a patch fixing that a while back.
> This one?
Yes.
> regulator: Ensure unique regulator debugfs directory names
> Ok. Seems to be only in next. I'm not sure it will work though because
> in this case the parent device is the same for both regulators on
> different PMICs that the RPM is controlling. I could be wrong though
> because I haven't tested it.
I'd say that if the driver is doing this then the driver is buggy - the
user should be able to distinguish between two regulators appearing for
the same device. Either the RPM should create dummy devices for the two
PMICs or something should insert the PMIC name into the regulator name
somewhere along the line (perhaps in the static data).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-06 16:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 22:55 [PATCH v2 0/5] Refactor Qualcomm RPM regulator to single platform_device Bjorn Andersson
2015-04-01 22:55 ` [PATCH v2 1/5] mfd: devicetree: bindings: Add Qualcomm RPM regulator subnodes Bjorn Andersson
2015-04-02 7:18 ` Lee Jones
2015-04-02 22:02 ` Stephen Boyd
2015-04-01 22:55 ` [PATCH v2 2/5] regulator: Introduce property to flag drms Bjorn Andersson
2015-04-02 8:54 ` Mark Brown
2015-04-02 21:35 ` Bjorn Andersson
2015-04-06 17:57 ` Mark Brown
2015-04-01 22:55 ` [PATCH v2 3/5] regulator: qcom: Don't enable DRMS in driver Bjorn Andersson
2015-04-02 22:02 ` Stephen Boyd
2015-04-01 22:55 ` [PATCH v2 4/5] regulator: qcom: Refactor of-parsing code Bjorn Andersson
2015-04-02 22:58 ` Stephen Boyd
2015-04-01 22:55 ` [PATCH v2 5/5] regulator: qcom: Rework to single platform device Bjorn Andersson
2015-04-02 23:02 ` Stephen Boyd
2015-04-06 16:59 ` Bjorn Andersson
2015-04-02 22:00 ` [PATCH v2 0/5] Refactor Qualcomm RPM regulator to single platform_device Stephen Boyd
2015-04-02 22:26 ` Mark Brown
2015-04-02 22:57 ` Stephen Boyd
2015-04-06 16:40 ` Bjorn Andersson
2015-04-06 16:51 ` Mark Brown [this message]
2015-04-06 17:11 ` Bjorn Andersson
2015-04-06 17:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150406165154.GP6023@sirena.org.uk \
--to=broonie@kernel.org \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox