* [PATCH] staging: lustre: Make cfs_sched_rehash static
@ 2015-04-07 2:02 Nickolaus Woodruff
2015-04-07 9:42 ` Sudip Mukherjee
2015-04-07 16:01 ` [HPDD-discuss] " Drokin, Oleg
0 siblings, 2 replies; 3+ messages in thread
From: Nickolaus Woodruff @ 2015-04-07 2:02 UTC (permalink / raw)
To: olegdrokin, andreasdilger, gregkh; +Cc: HPDD-discuss, devel, linux-kernel
This patch fixes the following sparse warning:
CHECK drivers/staging/lustre/lustre/libcfs/hash.c
drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol
'cfs_sched_rehash' was not declared. Should it be static?
Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@gmail.com>
---
drivers/staging/lustre/lustre/libcfs/hash.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c b/drivers/staging/lustre/lustre/libcfs/hash.c
index a55567e..a4920a2 100644
--- a/drivers/staging/lustre/lustre/libcfs/hash.c
+++ b/drivers/staging/lustre/lustre/libcfs/hash.c
@@ -116,7 +116,7 @@ module_param(warn_on_depth, uint, 0644);
MODULE_PARM_DESC(warn_on_depth, "warning when hash depth is high.");
#endif
-struct cfs_wi_sched *cfs_sched_rehash;
+static struct cfs_wi_sched *cfs_sched_rehash;
static inline void
cfs_hash_nl_lock(union cfs_hash_lock *lock, int exclusive) {}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: lustre: Make cfs_sched_rehash static
2015-04-07 2:02 [PATCH] staging: lustre: Make cfs_sched_rehash static Nickolaus Woodruff
@ 2015-04-07 9:42 ` Sudip Mukherjee
2015-04-07 16:01 ` [HPDD-discuss] " Drokin, Oleg
1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-04-07 9:42 UTC (permalink / raw)
To: Nickolaus Woodruff
Cc: olegdrokin, andreasdilger, gregkh, HPDD-discuss, devel,
linux-kernel
On Mon, Apr 06, 2015 at 10:02:27PM -0400, Nickolaus Woodruff wrote:
> This patch fixes the following sparse warning:
>
> CHECK drivers/staging/lustre/lustre/libcfs/hash.c
> drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol
> 'cfs_sched_rehash' was not declared. Should it be static?
you have not build tested your patch.
WARNING: "cfs_sched_rehash" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] undefined!
it has been used in lustre/lustre/libcfs/module.c
regards
sudip
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [HPDD-discuss] [PATCH] staging: lustre: Make cfs_sched_rehash static
2015-04-07 2:02 [PATCH] staging: lustre: Make cfs_sched_rehash static Nickolaus Woodruff
2015-04-07 9:42 ` Sudip Mukherjee
@ 2015-04-07 16:01 ` Drokin, Oleg
1 sibling, 0 replies; 3+ messages in thread
From: Drokin, Oleg @ 2015-04-07 16:01 UTC (permalink / raw)
To: Nickolaus Woodruff
Cc: Greg Kroah-Hartman, hpdd-discuss@lists.01.org,
<devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org> Mailing List,
Dilger, Andreas
If you checked the code, you would see that it's used in drivers/staging/lustre/lustre/libcfs/module.c too.
drivers/staging/lustre/lustre/libcfs/module.c:extern struct cfs_wi_sched *cfs_sched_rehash;
drivers/staging/lustre/lustre/libcfs/module.c: rc, &cfs_sched_rehash);
drivers/staging/lustre/lustre/libcfs/module.c: if (cfs_sched_rehash != NULL) {
drivers/staging/lustre/lustre/libcfs/module.c: cfs_wi_sched_destroy(cfs_sched_rehash);
drivers/staging/lustre/lustre/libcfs/module.c: cfs_sched_rehash = NULL;
On Apr 6, 2015, at 10:02 PM, Nickolaus Woodruff wrote:
> This patch fixes the following sparse warning:
>
> CHECK drivers/staging/lustre/lustre/libcfs/hash.c
> drivers/staging/lustre/lustre/libcfs/hash.c:119:21: warning: symbol
> 'cfs_sched_rehash' was not declared. Should it be static?
>
> Signed-off-by: Nickolaus Woodruff <nickolauswoodruff@gmail.com>
> ---
> drivers/staging/lustre/lustre/libcfs/hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c b/drivers/staging/lustre/lustre/libcfs/hash.c
> index a55567e..a4920a2 100644
> --- a/drivers/staging/lustre/lustre/libcfs/hash.c
> +++ b/drivers/staging/lustre/lustre/libcfs/hash.c
> @@ -116,7 +116,7 @@ module_param(warn_on_depth, uint, 0644);
> MODULE_PARM_DESC(warn_on_depth, "warning when hash depth is high.");
> #endif
>
> -struct cfs_wi_sched *cfs_sched_rehash;
> +static struct cfs_wi_sched *cfs_sched_rehash;
>
> static inline void
> cfs_hash_nl_lock(union cfs_hash_lock *lock, int exclusive) {}
> --
> 1.9.1
>
> _______________________________________________
> HPDD-discuss mailing list
> HPDD-discuss@lists.01.org
> https://lists.01.org/mailman/listinfo/hpdd-discuss
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-07 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-07 2:02 [PATCH] staging: lustre: Make cfs_sched_rehash static Nickolaus Woodruff
2015-04-07 9:42 ` Sudip Mukherjee
2015-04-07 16:01 ` [HPDD-discuss] " Drokin, Oleg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox