Re: [PATCH 04/13] thermal: Fix not emulating critical temperatures

Eduardo Valentin
2015-04-07T02:08:25Z

[-- Attachment #1: Type: text/plain, Size: 1905 bytes --]

On Fri, Mar 27, 2015 at 06:23:18AM +0100, Sascha Hauer wrote:
> Hi Amit,
>
> On Fri, Mar 27, 2015 at 08:35:50AM +0530, amit daniel kachhap wrote:
> > Hi Sascha,
> >
> > > -#ifdef CONFIG_THERMAL_EMULATION
> > > - if (!tz->emul_temperature)
> > > - goto skip_emul;
> > > -
> > > - for (count = 0; count < tz->trips; count++) {
> > > - ret = tz->ops->get_trip_type(tz, count, &type);
> > > - if (!ret && type == THERMAL_TRIP_CRITICAL) {
> > > - ret = tz->ops->get_trip_temp(tz, count, &crit_temp);
> > > - break;
> > > - }
> > > - }
> > > -
> > > - if (ret)
> > > - goto skip_emul;
> > >
> > > - if (*temp < crit_temp)
> > I guess this check is confusing. Actually instead of returning
> > emulating temperature it is returning actual temperature. But the
> > important thing to look here is that actual temperature is higher than
> > critical temperature. So this check prevents the user from suppressing
> > the critical temperature and hence prevents from burning up the chip.
>
> Indeed the check is confusing, but now it makes perfectly sense. I'll
> look at the patch again and maybe turn into a patch just adding a
> comment to clarify this.

That will be great. Thanks Sascha.

>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]