From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753283AbbDGJpr (ORCPT ); Tue, 7 Apr 2015 05:45:47 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:49540 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbbDGJpq (ORCPT ); Tue, 7 Apr 2015 05:45:46 -0400 Date: Tue, 7 Apr 2015 12:45:23 +0300 From: Dan Carpenter To: Sudip Mukherjee Cc: Willy Tarreau , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: panel: remove duplicate code Message-ID: <20150407094522.GZ16501@mwanda> References: <1428395101-20098-1-git-send-email-sudipm.mukherjee@gmail.com> <20150407084930.GD10964@mwanda> <20150407092502.GA20278@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150407092502.GA20278@sudip-PC> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote: > On Tue, Apr 07, 2015 at 11:49:30AM +0300, Dan Carpenter wrote: > > On Tue, Apr 07, 2015 at 01:55:01PM +0530, Sudip Mukherjee wrote: > > > > I hadn't looked at this driver much before. It sucks that > > parport_driver ->attach() functions can't fail... > > then maybe, we can change the code of parport. currently attach and > parport_register_driver never fails. we can modify it so that if attach > fails then parport_register_driver will also fail. will not be that much > difficult as it has been used only in 13 places. > your views ? If you write the patch then I will review it. :) > > and since we are discussing parallel ports, few days back i saw one > post in ubuntuforums that his scanner is not working because of > lack of ppscsi.I mailed Tim Waugh, but he is not interested to work > with ppscsi anymore. parallel port scanners are almost a thing of the past > now. do you think it is worth that i pick up the code and modify > it for our latest kernel and submit to Greg ? If you want to do the work, I won't say no! :P regards, dan carpenter