From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbbDGKlU (ORCPT ); Tue, 7 Apr 2015 06:41:20 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:33662 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbbDGKlR (ORCPT ); Tue, 7 Apr 2015 06:41:17 -0400 Date: Tue, 7 Apr 2015 16:11:10 +0530 From: Sudip Mukherjee To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: dgnc: check if kzalloc fails in dgnc_tty_init() Message-ID: <20150407104110.GB28119@sudip-PC> References: <1428402392-15817-1-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1428402392-15817-1-git-send-email-giedrius.statkevicius@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 01:26:32PM +0300, Giedrius Statkevičius wrote: > kzalloc() could fail so add a check and return -ENOMEM if it does that gets > propogated to the pci layer > > Signed-off-by: Giedrius Statkevičius > --- > drivers/staging/dgnc/dgnc_tty.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c > index 61d5a8e..23337da 100644 > --- a/drivers/staging/dgnc/dgnc_tty.c > +++ b/drivers/staging/dgnc/dgnc_tty.c > @@ -311,6 +311,8 @@ int dgnc_tty_init(struct dgnc_board *brd) > * interrupt context, and there are no locks held. > */ > brd->channels[i] = kzalloc(sizeof(*brd->channels[i]), GFP_KERNEL); > + if (!brd->channels[i]) > + return -ENOMEM; won't this create memory leak ? suppose you have brd->nasync = 3 and kzalloc fails when i=2, and you return -ENOMEM, then what happens to the memory already allocated to brd->channels[0] and brd->channels[1] ? regards sudip