public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible
Date: Tue, 7 Apr 2015 16:03:17 +0200	[thread overview]
Message-ID: <20150407140316.GA17681@gmail.com> (raw)
In-Reply-To: <CANCZXo7VkpDdzAYR7Mw3=v_v=ckRje7rTjK-2upKd3bBo4Mefw@mail.gmail.com>


* Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> 2015-04-07 17:35 GMT+06:00 Ingo Molnar <mingo@kernel.org>:
> >
> >
> > So if you set up earlyprintk via CONFIG_CMDLINE_OVERRIDE it just
> > works?
> >
> 
> Look, how i did it. I set:
> 
> CONFIG_CMDLINE_BOOL =y
> CONFIG_CMDLINE_OVERRIDE =y
> 
> and passed following string:
> 
> [=root=/dev/sdb earlyprintk=ttyS0 loglevel=7 debug rdinit=/sbin/init
> root=/dev/ram memblock=debug]
> 
> to the CONFIG_CMDLINE.
> 
> Now i put two early_printk calls before and after earlyprintk initialization:
> 
>     early_printk("before setup_early_printk \n");
>     setup_early_printk(boot_command_line);
>     early_printk("after setup_early_printk \n");
> 
> And i don't see first string, but see last.
> 
> Did i make something wrong?

Yes, you need to check how and where in the arch init code 
boot_command_line is set up in the CONFIG_CMDLINE_OVERRIDE=y case.

Thanks,

	Ingo

  reply	other threads:[~2015-04-07 14:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 11:02 [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible Alexander Kuleshov
2015-04-07 11:02 ` [PATCH 2/2] x86/earlyprintk: setup earlyprintk " Alexander Kuleshov
2015-04-07 11:07   ` Ingo Molnar
2015-04-07 11:09 ` [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early " Ingo Molnar
2015-04-07 11:24   ` Alexander Kuleshov
2015-04-07 11:35     ` Ingo Molnar
2015-04-07 11:47       ` Alexander Kuleshov
2015-04-07 14:03         ` Ingo Molnar [this message]
2015-04-07 16:49           ` Alexander Kuleshov
2015-04-07 17:00             ` Alexander Kuleshov
2015-04-07 17:30               ` Alexander Kuleshov
2015-04-07 11:31 ` [PATCH 2/2 v2] x86/earlyprintk: setup earlyprintk " Alexander Kuleshov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150407140316.GA17681@gmail.com \
    --to=mingo@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=kuleshovmail@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox