commit reverted in staging/sm750fb

commit reverted in staging/sm750fb

[Sudip Mukherjee]

Hi Greg,
I saw that you have reveretd one commit
<6ad6b5ed3e2472b399b567a2f036006bf25df467>
"Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
I was trying to search for that patch, but it seems I am not able to
find that in my personal mails nor in lkml. can you please let me know
when it was sent..

And I must say sorry for missing a new file creation in a patch.

regards
sudip

Re: commit reverted in staging/sm750fb

[Fabio Estevam]

On Tue, Apr 7, 2015 at 10:56 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:
> Hi Greg,
> I saw that you have reveretd one commit
> <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> I was trying to search for that patch, but it seems I am not able to
> find that in my personal mails nor in lkml. can you please let me know
> when it was sent..

Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.

Regards,

Fabio Estevam

Re: commit reverted in staging/sm750fb

[Sudip Mukherjee]

On Tue, Apr 07, 2015 at 11:01:57AM -0300, Fabio Estevam wrote:
> On Tue, Apr 7, 2015 at 10:56 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > Hi Greg,
> > I saw that you have reveretd one commit
> > <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> > "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> > I was trying to search for that patch, but it seems I am not able to
> > find that in my personal mails nor in lkml. can you please let me know
> > when it was sent..
> 
> Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.
I have already seen the patch. But being the maintainer of that driver
i hold myself responsible for missing a new file creation in a patch.
So i was trying to search for that patch in my mails and also in lkml,
but i could not find it, so thought of mailing and asking. :(

regards
sudip

> 
> Regards,
> 
> Fabio Estevam

Re: commit reverted in staging/sm750fb

[Fabio Estevam]

On Tue, Apr 7, 2015 at 11:08 AM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:

>> Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.
> I have already seen the patch. But being the maintainer of that driver
> i hold myself responsible for missing a new file creation in a patch.
> So i was trying to search for that patch in my mails and also in lkml,
> but i could not find it, so thought of mailing and asking. :(

The problem with commit 6ad6b5ed3e247 is this hunk:

diff --git a/ret.ou b/ret.ou
new file mode 100644
index 0000000..e69de29

Regards,

Fabio Estevam

Re: commit reverted in staging/sm750fb

[Sudip Mukherjee]

On Tue, Apr 07, 2015 at 11:24:43AM -0300, Fabio Estevam wrote:
> On Tue, Apr 7, 2015 at 11:08 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> 
> >> Just run 'git show 6ad6b5ed3e247' in linux-next and you can see such commit.
> > I have already seen the patch. But being the maintainer of that driver
> > i hold myself responsible for missing a new file creation in a patch.
> > So i was trying to search for that patch in my mails and also in lkml,
> > but i could not find it, so thought of mailing and asking. :(
> 
> The problem with commit 6ad6b5ed3e247 is this hunk:
> 
> diff --git a/ret.ou b/ret.ou
> new file mode 100644
> index 0000000..e69de29
that also I have seen.but what I am trying to say is that I am not finding
any reference of that patch in my mails or in lkml.org,

regards
sudip

> 
> Regards,
> 
> Fabio Estevam

Re: commit reverted in staging/sm750fb

[Greg KH]

On Tue, Apr 07, 2015 at 07:26:53PM +0530, Sudip Mukherjee wrote:
> Hi Greg,
> I saw that you have reveretd one commit
> <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> I was trying to search for that patch, but it seems I am not able to
> find that in my personal mails nor in lkml. can you please let me know
> when it was sent..

It came in through the Outreachy mailing list, as part of the intern
application process.  Sorry about the extra file, I missed it, it was my
fault.

thanks,

greg k-h

Re: commit reverted in staging/sm750fb

[Sudip Mukherjee]

On Tue, Apr 07, 2015 at 04:34:54PM +0200, Greg KH wrote:
> On Tue, Apr 07, 2015 at 07:26:53PM +0530, Sudip Mukherjee wrote:
> > Hi Greg,
> > I saw that you have reveretd one commit
> > <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> > "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> > I was trying to search for that patch, but it seems I am not able to
> > find that in my personal mails nor in lkml. can you please let me know
> > when it was sent..
> 
> It came in through the Outreachy mailing list, as part of the intern
> application process.  Sorry about the extra file, I missed it, it was my
> fault.
can i, in any way, help in the Outreachy? 

regards
sudip
> 
> thanks,
> 
> greg k-h

Re: commit reverted in staging/sm750fb

[Greg KH]

On Tue, Apr 07, 2015 at 08:31:44PM +0530, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 04:34:54PM +0200, Greg KH wrote:
> > On Tue, Apr 07, 2015 at 07:26:53PM +0530, Sudip Mukherjee wrote:
> > > Hi Greg,
> > > I saw that you have reveretd one commit
> > > <6ad6b5ed3e2472b399b567a2f036006bf25df467>
> > > "Staging: sm750fb: Fix C99 Comments" in staging/sm750fb.
> > > I was trying to search for that patch, but it seems I am not able to
> > > find that in my personal mails nor in lkml. can you please let me know
> > > when it was sent..
> > 
> > It came in through the Outreachy mailing list, as part of the intern
> > application process.  Sorry about the extra file, I missed it, it was my
> > fault.
> can i, in any way, help in the Outreachy? 

The application process is all over now, so thanks for the offer.  Next
round of applications will happen in 6 months, and we can always use
review help for the patches that come in.  Just let me know then and
I'll be glad to point you at the proper lists.

thanks,

greg k-h