From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756021AbbDGPrI (ORCPT ); Tue, 7 Apr 2015 11:47:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:26983 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753494AbbDGPrF (ORCPT ); Tue, 7 Apr 2015 11:47:05 -0400 Date: Tue, 7 Apr 2015 18:46:46 +0300 From: Dan Carpenter To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com Subject: Re: [PATCH v3] staging: dgnc: check if kzalloc fails in dgnc_tty_init() Message-ID: <20150407154646.GL16501@mwanda> References: <1428410417-18524-1-git-send-email-giedrius.statkevicius@gmail.com> <1428415875-23797-1-git-send-email-giedrius.statkevicius@gmail.com> <20150407144832.GK16501@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 07, 2015 at 06:35:51PM +0300, Giedrius Statkevičius wrote: > Well, the point of the patch is to put alloc and checks in one place to make the > code less error and bug prone and fix some of bugs where ->channels[i] isn't > checked. Fine, fine. I can accept that. One patch is also ok. regards, dan carpenter