From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753390AbbDGReY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Apr 2015 13:34:24 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60164 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753243AbbDGReW (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Apr 2015 13:34:22 -0400
Date: Tue, 7 Apr 2015 19:33:37 +0200
From: Jiri Olsa <jolsa@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        David Ahern <dsahern@gmail.com>, Stephane Eranian <eranian@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/2] perf, record: Add clockid parameter
Message-ID: <20150407173337.GB22603@krava.redhat.com>
References: <20150407090952.908289259@infradead.org>
 <20150407091150.583976936@infradead.org>
 <20150407154851.GR23123@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150407154851.GR23123@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 07, 2015 at 05:48:51PM +0200, Peter Zijlstra wrote:
> On Tue, Apr 07, 2015 at 11:09:53AM +0200, Peter Zijlstra wrote:
> > @@ -739,6 +813,7 @@ static struct record record = {
> >  			.uses_mmap   = true,
> >  			.default_per_cpu = true,
> >  		},
> > +		.clockid             = -1,
> >  	},
> 
> As spotted by dahern this is not working well for all other record_opts
> instances, fix that by adding a use_clockid field just like
> perf_event_attr has.

hum, havent realized that.. I saw Arnaldo already included
this one in pull req., anyway FWIW it looks ok ;-)

jirka