From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753363AbbDGUUr (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Apr 2015 16:20:47 -0400
Received: from mail.kernel.org ([198.145.29.136]:34489 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752472AbbDGUUq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Apr 2015 16:20:46 -0400
Date: Tue, 7 Apr 2015 17:20:45 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Jiri Olsa <jolsa@redhat.com>, John Stultz <john.stultz@linaro.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Stephane Eranian <eranian@google.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 15/16] perf record: Add clockid parameter
Message-ID: <20150407202045.GB26501@kernel.org>
References: <1428424862-30032-1-git-send-email-acme@kernel.org>
 <1428424862-30032-16-git-send-email-acme@kernel.org>
 <55242AB7.9040602@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <55242AB7.9040602@gmail.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Tue, Apr 07, 2015 at 01:06:31PM -0600, David Ahern escreveu:
> fails to compile on RHEL6/CentOS6/OL6 ...
 
> On 4/7/15 10:41 AM, Arnaldo Carvalho de Melo wrote:
> >+/*
> >+ * Doesn't appear to have made it into userspace so define here if missing.
> >+ */
> >+#ifndef CLOCK_TAI
> >+#define CLOCK_TAI 11
> >+#endif
> >+
> >+static const struct clockid_map clockids[] = {
> >+	/* available for all events, NMI safe */
> >+	CLOCKID_MAP("monotonic", CLOCK_MONOTONIC),
> >+	CLOCKID_MAP("monotonic_raw", CLOCK_MONOTONIC_RAW),
> >+
> >+	/* available for some events */
> >+	CLOCKID_MAP("realtime", CLOCK_REALTIME),
> >+	CLOCKID_MAP("boottime", CLOCK_BOOTTIME),
> >+	CLOCKID_MAP("tai", CLOCK_TAI),
> >+
> >+	/* available for the lazy */
> >+	CLOCKID_MAP("mono", CLOCK_MONOTONIC),
> >+	CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
> >+	CLOCKID_MAP("real", CLOCK_REALTIME),
> >+	CLOCKID_MAP("boot", CLOCK_BOOTTIME),
> >+
 
> builtin-record.c:738: error: ‘CLOCK_BOOTTIME’ undeclared here (not in a
> function)
> make[2]: *** [/tmp/perf/builtin-record.o] Error 1
> make[1]: *** [/tmp/perf/perf-in.o] Error 2
> make: *** [all] Error 2
> 
> Need this similar to CLOCK_TAI:

Fixed on perf-core-for-mingo-2 tag, Ingo, up to you.

- Arnaldo