Re: [PATCH v9 14/30] PCI: Introduce pci_host_bridge_ops to support host specific operations

Daniel Axtens
2015-04-07T07:04:41Z

[-- Attachment #1: Type: text/plain, Size: 843 bytes --]

On Fri, 2015-04-03 at 17:25 +0800, Yijing Wang wrote:
> Now we have weak functions like pcibios_root_bridge_prepare()
> to setup pci host bridge, We could introduce pci_host_bridge_ops
> which contain host bridge specific ops to setup pci_host_bridge.
> Then host bridge driver could add pci_host_bridge_ops hooks
> intead of weak function to setup pci_host_bridge.
> This patch add following pci_host_bridge_ops hooks:
>
> pci_host_bridge_ops {
> struct pci_ops *ops;
Trivial nit, but this is 'struct pci_ops *pci_ops' in the code below.

> +struct pci_host_bridge;
> +struct pci_host_bridge_ops {
> + struct pci_ops *pci_ops;
> + int (*prepare)(struct pci_host_bridge *host);
> + void (*set_root_bus_speed)(struct pci_host_bridge *host);
> + int (*scan_bus)(struct pci_host_bridge *host);
> +};
> +

Regards,
Daniel

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 860 bytes --]