From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753395AbbDHJrf (ORCPT <rfc822;w@1wt.eu>);
	Wed, 8 Apr 2015 05:47:35 -0400
Received: from casper.infradead.org ([85.118.1.10]:45863 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751132AbbDHJrd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 8 Apr 2015 05:47:33 -0400
Date: Wed, 8 Apr 2015 11:47:23 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
        Adrian Hunter <adrian.hunter@intel.com>,
        David Ahern <dsahern@gmail.com>, Stephane Eranian <eranian@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 1/2] perf, record: Add clockid parameter
Message-ID: <20150408094723.GA23123@twins.programming.kicks-ass.net>
References: <20150407090952.908289259@infradead.org>
 <20150407091150.583976936@infradead.org>
 <20150407154851.GR23123@twins.programming.kicks-ass.net>
 <20150407173337.GB22603@krava.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150407173337.GB22603@krava.redhat.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 07, 2015 at 07:33:37PM +0200, Jiri Olsa wrote:
> On Tue, Apr 07, 2015 at 05:48:51PM +0200, Peter Zijlstra wrote:
> > On Tue, Apr 07, 2015 at 11:09:53AM +0200, Peter Zijlstra wrote:
> > > @@ -739,6 +813,7 @@ static struct record record = {
> > >  			.uses_mmap   = true,
> > >  			.default_per_cpu = true,
> > >  		},
> > > +		.clockid             = -1,
> > >  	},
> > 
> > As spotted by dahern this is not working well for all other record_opts
> > instances, fix that by adding a use_clockid field just like
> > perf_event_attr has.
> 
> hum, havent realized that.. I saw Arnaldo already included
> this one in pull req., anyway FWIW it looks ok ;-)

Yeah, I was slightly surprised to find out record_opts were used outside
of builtin-record.c, maybe a rename might be in order.