From: Mark Brown <broonie@kernel.org>
To: Caesar Wang <wxt@rock-chips.com>
Cc: Sonny Rao <sonnyrao@chromium.org>,
Cheng-Yi Chiang <cychiang@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
zhengxing <zhengxing@rock-chips.com>,
"jay.xu" <xjq@rock-chips.com>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org, Dylan Reid <dgreid@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Tushar Behera <tushar.b@samsung.com>
Subject: Re: [PATCH] ASoC: max98090: add shutdown callback for max98090
Date: Wed, 8 Apr 2015 10:50:05 +0100 [thread overview]
Message-ID: <20150408095005.GS6023@sirena.org.uk> (raw)
In-Reply-To: <1428483128-23498-2-git-send-email-wxt@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 712 bytes --]
On Wed, Apr 08, 2015 at 04:52:08PM +0800, Caesar Wang wrote:
> +static void max98090_i2c_shutdown(struct i2c_client *i2c)
> +{
> + struct max98090_priv *max98090 = dev_get_drvdata(&i2c->dev);
> +
> + dev_info(&i2c->dev, "shut down device\n");
Remove this, it's adding noise.
> +
> + /* Enable volume smoothing, disable zero cross. This will cause
> + * a quick 40ms ramp to mute on shutdown.
> + */
> + regmap_write(max98090->regmap,
> + M98090_REG_LEVEL_CONTROL, M98090_VSENN_MASK);
> + regmap_write(max98090->regmap,
> + M98090_REG_DEVICE_SHUTDOWN, 0x00);
> + msleep(40);
> +}
This is OK but equivalent code should be being added to the driver
remove path as the same thing should be happening there.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-04-08 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 8:52 [PATCH 0/1] ASoC: max98090: add shutdown callback for max98090 Caesar Wang
2015-04-08 8:52 ` [PATCH] " Caesar Wang
2015-04-08 9:25 ` Heiko Stübner
2015-04-08 10:14 ` Caesar Wang
2015-04-08 9:50 ` Mark Brown [this message]
2015-04-08 10:15 ` Caesar Wang
2015-04-08 9:48 ` [PATCH 0/1] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150408095005.GS6023@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cychiang@chromium.org \
--cc=dgreid@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=jarkko.nikula@linux.intel.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=sonnyrao@chromium.org \
--cc=tiwai@suse.de \
--cc=tushar.b@samsung.com \
--cc=wxt@rock-chips.com \
--cc=xjq@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox