public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vlad Dogaru <vlad.dogaru@intel.com>
To: Irina Tirdea <irina.tirdea@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Hartmut Knaack <knaack.h@gmx.de>
Subject: Re: [PATCH] iio: pressure: bmp280: fix temp compensation
Date: Wed, 8 Apr 2015 18:30:34 +0300	[thread overview]
Message-ID: <20150408153034.GA23781@vdogaru> (raw)
In-Reply-To: <1428506772-23710-1-git-send-email-irina.tirdea@intel.com>

On Wed, Apr 08, 2015 at 06:26:12PM +0300, Irina Tirdea wrote:
> Temperature reads on bmp280 device always return 0,
> due to a missing step in the compensation formula
> (data->tfine is never initialized).
> 
> Initialize data->tfine value so we get correct
> temperature and pressure values.
> 
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>

Reviewed-by: Vlad Dogaru <vlad.dogaru@intel.com>

Nice catch, this must have been lost during a refactoring.

Thanks,
Vlad

  reply	other threads:[~2015-04-08 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 15:26 [PATCH] iio: pressure: bmp280: fix temp compensation Irina Tirdea
2015-04-08 15:30 ` Vlad Dogaru [this message]
2015-04-09 11:56   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150408153034.GA23781@vdogaru \
    --to=vlad.dogaru@intel.com \
    --cc=irina.tirdea@intel.com \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox