public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] virtio_config: reorder functions
Date: Wed, 8 Apr 2015 16:49:46 +0200	[thread overview]
Message-ID: <20150408164933-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1427814977-11504-1-git-send-email-mst@redhat.com>

On Tue, Mar 31, 2015 at 05:17:25PM +0200, Michael S. Tsirkin wrote:
> This simply reorders functions in virtio_config
> so width access wrapper helpers are all together.
> Drops an extra empty line while we are at it.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Ping

> ---
>  include/linux/virtio_config.h | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)
> 
> diff --git a/include/linux/virtio_config.h b/include/linux/virtio_config.h
> index ed1e0d5..1e306f7 100644
> --- a/include/linux/virtio_config.h
> +++ b/include/linux/virtio_config.h
> @@ -298,13 +298,6 @@ static inline __virtio64 cpu_to_virtio64(struct virtio_device *vdev, u64 val)
>  		}							\
>  	} while(0)
>  
> -static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset)
> -{
> -	u8 ret;
> -	vdev->config->get(vdev, offset, &ret, sizeof(ret));
> -	return ret;
> -}
> -
>  /* Read @count fields, @bytes each. */
>  static inline void __virtio_cread_many(struct virtio_device *vdev,
>  				       unsigned int offset,
> @@ -326,7 +319,6 @@ static inline void __virtio_cread_many(struct virtio_device *vdev,
>  	} while (gen != old);
>  }
>  
> -
>  static inline void virtio_cread_bytes(struct virtio_device *vdev,
>  				      unsigned int offset,
>  				      void *buf, size_t len)
> @@ -334,6 +326,13 @@ static inline void virtio_cread_bytes(struct virtio_device *vdev,
>  	__virtio_cread_many(vdev, offset, buf, len, 1);
>  }
>  
> +static inline u8 virtio_cread8(struct virtio_device *vdev, unsigned int offset)
> +{
> +	u8 ret;
> +	vdev->config->get(vdev, offset, &ret, sizeof(ret));
> +	return ret;
> +}
> +
>  static inline void virtio_cwrite8(struct virtio_device *vdev,
>  				  unsigned int offset, u8 val)
>  {
> -- 
> MST

  reply	other threads:[~2015-04-08 14:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-31 15:17 [PATCH] virtio_config: reorder functions Michael S. Tsirkin
2015-04-08 14:49 ` Michael S. Tsirkin [this message]
2015-04-09 12:46   ` Cornelia Huck
2015-04-10  3:21     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150408164933-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox