From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754947AbbDIAJt (ORCPT ); Wed, 8 Apr 2015 20:09:49 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:33488 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753049AbbDIAJq (ORCPT ); Wed, 8 Apr 2015 20:09:46 -0400 Date: Thu, 9 Apr 2015 02:09:34 +0200 From: Ralf Baechle To: Guenter Roeck Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Andy Lutomirski , David Daney Subject: Re: [PATCH] mips: Fix build if PERF_EVENTS is configured Message-ID: <20150409000934.GA21107@linux-mips.org> References: <1428524992-5979-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428524992-5979-1-git-send-email-linux@roeck-us.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2015 at 01:29:52PM -0700, Guenter Roeck wrote: > mips builds fail in -next as follows if PERF_EVENTS is configured. > > kernel/built-in.o: In function `perf_sample_regs_user': > kernel/events/core.c:4828: undefined reference to `perf_get_regs_user' > > The problem is caused by commit 3478e32c1545 ("MIPS: Add user stack and > registers to perf.") in combination with commit 88a7c26af8da ("perf: > Move task_pt_regs sampling into arch code"), which introduces > perf_get_regs_user(). > > Cc: Andy Lutomirski > Cc: David Daney > Signed-off-by: Guenter Roeck I've already applied the same change locally but due to patch ordering constraints I'm considering to temporarily pull this patch until the perf stuff and the remainder of the MIPS changes are in 4.1 or so. Thanks, Ralf