From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754678AbbDIA2z (ORCPT ); Wed, 8 Apr 2015 20:28:55 -0400 Received: from one.firstfloor.org ([193.170.194.197]:40192 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753165AbbDIA2x (ORCPT ); Wed, 8 Apr 2015 20:28:53 -0400 Date: Thu, 9 Apr 2015 02:28:51 +0200 From: Andi Kleen To: Joe Perches Cc: Andrew Morton , Andy Whitcroft , Andi Kleen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] checkpatch: Add a test for const with __read_mostly uses Message-ID: <20150409002851.GV2366@two.firstfloor.org> References: <1428498405-7019-1-git-send-email-andi@firstfloor.org> <1428498405-7019-2-git-send-email-andi@firstfloor.org> <20150408153554.65c87de78f1c2289483f67e8@linux-foundation.org> <20150408235239.GU2366@two.firstfloor.org> <1428538489.22406.65.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428538489.22406.65.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2015 at 05:14:49PM -0700, Joe Perches wrote: > const objects shouldn't be __read_mostly. They are read-only. > > Marking these objects as __read_mostly causes section conflicts > with LTO linking. > > So add a test to try to avoid this issue. Thanks Joe. Looks good thanks. I suspect excluding * will miss quite a few cases, but there's no way around it. -Andi