From: Greg KH <gregkh@linuxfoundation.org>
To: Matthew Garrett <mjg59@coreos.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: Prefer firmware values when determining whether a port is removable
Date: Thu, 9 Apr 2015 11:31:30 +0200 [thread overview]
Message-ID: <20150409093130.GC883@kroah.com> (raw)
In-Reply-To: <1428536161-2978-1-git-send-email-mjg59@coreos.com>
On Wed, Apr 08, 2015 at 04:36:00PM -0700, Matthew Garrett wrote:
> Windows appears to pay more attention to the ACPI values than any hub
> configuration, so prefer the firmware's opinion on whether a port is
> fixed or removable before falling back to the hub values.
>
> Signed-off-by: Matthew Garrett <mjg59@coreos.com>
> ---
> drivers/usb/core/hub.c | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
I like your trust in firmware :)
Anyway, is this all a Windows 8 requirement? If so, I'll feel
comfortable making these changes, otherwise we are at the mercy of the
bios people to randomly get things right, and we all know how often that
works...
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-09 9:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 23:36 [PATCH 1/2] usb: Prefer firmware values when determining whether a port is removable Matthew Garrett
2015-04-08 23:36 ` [PATCH 2/2] usb: Set unused ports to "fixed" rather than "unknown" Matthew Garrett
2015-04-09 9:31 ` Greg KH [this message]
2015-04-09 17:19 ` [PATCH 1/2] usb: Prefer firmware values when determining whether a port is removable Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409093130.GC883@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mjg59@coreos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).