From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933340AbbDIKwL (ORCPT ); Thu, 9 Apr 2015 06:52:11 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58714 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933205AbbDIKwI (ORCPT ); Thu, 9 Apr 2015 06:52:08 -0400 Date: Thu, 9 Apr 2015 11:52:02 +0100 From: Mark Brown To: Michael Welling Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150409105202.GU6023@sirena.org.uk> References: <1428528961-7838-1-git-send-email-mwelling@ieee.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H6tyVQTLTcEE6OpN" Content-Disposition: inline In-Reply-To: <1428528961-7838-1-git-send-email-mwelling@ieee.org> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] spi: omap2-mcspi: Add support for GPIO chipselects X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --H6tyVQTLTcEE6OpN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 08, 2015 at 04:36:01PM -0500, Michael Welling wrote: > This patch allows for GPIOs specified in the devicetree to be used as SPI chipselects > on TI OMAP2 SoCs. Please keep your commit messages under 80 columns. > + if (gpio_is_valid(spi->cs_gpio)) { > + if (gpio_request(spi->cs_gpio, dev_name(&spi->dev)) == 0) > + gpio_direction_output(spi->cs_gpio, > + !(spi->mode & SPI_CS_HIGH)); > + } For this to work we need to be sure that unspecified GPIOs are invalid which isn't normally the default - zero tends to be a valid GPIO and that's also the default for otherwise uninitialized data. Is there something that takes care of this? --H6tyVQTLTcEE6OpN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVJlnRAAoJECTWi3JdVIfQ6IQH/AlTgrRG/bMnJ/KVhssjyomk GXdfyJaL2XpmfQNTfPTHQzvHA2PVRwfQYINyF4+Haa/VpMogFy+D+3hQo06Gv2nn aBH3LAx017QrZ2xCLA+/6IehzABwg58HOiOaPEei+gL5WOofpSkUCLqOYSpKKDET OFW8Y88FlX8b5r29ncl/BZszMMzw4SHtQZds5Ul6IpXq7s/ulUX+HOHXlfBnOOAh p1CPjtqBDtUg0gLE3YSqIxQM2qqrEcMFVK0aXkuLoRmjF8Ruo0uv5x+A6iYTipfj QE75LgVtbu044hS0e36nZfc7dAc3OEqvJnvm5xsrFeGtvd5xUp3NP84SEho2hJI= =Drvz -----END PGP SIGNATURE----- --H6tyVQTLTcEE6OpN--