From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755267AbbDIMgr (ORCPT ); Thu, 9 Apr 2015 08:36:47 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:25683 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755058AbbDIMgo (ORCPT ); Thu, 9 Apr 2015 08:36:44 -0400 Date: Thu, 9 Apr 2015 15:36:33 +0300 From: Dan Carpenter To: Quentin Lambert Cc: "David S. Miller" , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL Message-ID: <20150409123633.GN10964@mwanda> References: <1428579988-10167-1-git-send-email-lambert.quentin@gmail.com> <1428579988-10167-3-git-send-email-lambert.quentin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428579988-10167-3-git-send-email-lambert.quentin@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2015 at 01:46:28PM +0200, Quentin Lambert wrote: > Both pmac_ide_init_dma and ide_dma_sgiioc4 are stored in the init_dma field of > an ide_port_info structure. This field seems to only be called from contexts > where sleep is allowed. Therefore, this patch replaces uses of GFP_ATOMIC by > GFP_KERNEL. > > Signed-off-by: Quentin Lambert Oh. They're not GFP_ATOMIC. Fold these two patches together into one patch and resend. regards, dan carpenter