From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932248AbbDJIlB (ORCPT ); Fri, 10 Apr 2015 04:41:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46308 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754270AbbDJIk7 (ORCPT ); Fri, 10 Apr 2015 04:40:59 -0400 Date: Fri, 10 Apr 2015 10:40:55 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@Kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools: Print stddev in CSV mode with -a Message-ID: <20150410084055.GB27593@krava> References: <1428504501-9102-1-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428504501-9102-1-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 08, 2015 at 07:48:21AM -0700, Andi Kleen wrote: > From: Andi Kleen > > Currently with -r.. -a -A ,x or other aggregation we don't print the > stddev into the CSV output. Just drop the checks preventing this. > > Signed-off-by: Andi Kleen we already print this print_counter_aggr so I think we can consider this as bugfix even though it changes current csv format Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/builtin-stat.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c > index d4d1b77..3de0ea5 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -1282,8 +1282,7 @@ static void print_aggr(char *prefix) > else > abs_printout(id, nr, counter, uval); > > - if (!csv_output) > - print_noise(counter, 1.0); > + print_noise(counter, 1.0); > > print_running(run, ena); > fputc('\n', output); > @@ -1392,8 +1391,7 @@ static void print_counter(struct perf_evsel *counter, char *prefix) > else > abs_printout(cpu, 0, counter, uval); > > - if (!csv_output) > - print_noise(counter, 1.0); > + print_noise(counter, 1.0); > print_running(run, ena); > > fputc('\n', output); > -- > 2.3.3 >