From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965712AbbDJNrX (ORCPT ); Fri, 10 Apr 2015 09:47:23 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:41126 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965500AbbDJNrS (ORCPT ); Fri, 10 Apr 2015 09:47:18 -0400 Date: Fri, 10 Apr 2015 15:47:11 +0200 From: Ralf Baechle To: Lars Persson Cc: paul.burton@imgtec.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Lars Persson Subject: Re: [PATCH] MIPS: Fix HIGHMEM crash in __update_cache(). Message-ID: <20150410134711.GC21107@linux-mips.org> References: <1428672084-20676-1-git-send-email-larper@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428672084-20676-1-git-send-email-larper@axis.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 10, 2015 at 03:21:24PM +0200, Lars Persson wrote: > Commit 8b5fe5e54b47 ("MIPS: Fix race condition in lazy cache flushing.") > triggered NULL pointer dereferences on systems with HIGHMEM. > > The problem was caused by not clearing the PG_dcache_dirty flag in > flush_icache_page() and thus we enter __update_cache() that lacks > support for HIGHMEM. Thanks, I've folded this patch into the original 8b5fe5e54b47 commit. Ralf