From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756530AbbDJS2E (ORCPT ); Fri, 10 Apr 2015 14:28:04 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47061 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557AbbDJS2A (ORCPT ); Fri, 10 Apr 2015 14:28:00 -0400 Date: Fri, 10 Apr 2015 21:27:42 +0300 From: Dan Carpenter To: Vitaly Kuznetsov Cc: "K. Y. Srinivasan" , devel@linuxdriverproject.org, Radim Krcmar , Greg Kroah-Hartman , Haiyang Zhang , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v3 03/21] Drivers: hv: kvp: move poll_channel() to hyperv_vmbus.h Message-ID: <20150410182742.GQ10964@mwanda> References: <1428568730-6030-1-git-send-email-vkuznets@redhat.com> <1428568730-6030-4-git-send-email-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428568730-6030-4-git-send-email-vkuznets@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 09, 2015 at 10:38:32AM +0200, Vitaly Kuznetsov wrote: > ..., make it inline and rename it to hv_poll_channel() so it can be reused > in other hv_util modules. > The "...," is fine in the git log but I noticed recently that if you're reading patches in a web archive then often the subject and the body are several lines apart. http://marc.info/?l=linux-api&m=142856917031730&w=2 It's awkward to follow. regards, dan carpenter