From: Greg KH <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH WIP] parport: add device model
Date: Sat, 11 Apr 2015 09:27:16 +0200 [thread overview]
Message-ID: <20150411072716.GD10063@kroah.com> (raw)
In-Reply-To: <20150411052651.GC3496@sudip-PC>
On Sat, Apr 11, 2015 at 10:56:51AM +0530, Sudip Mukherjee wrote:
> > I know that I have done a rubbish review. I'm going to have to review
> > this properly later.
> main thing i wanted to know is if my approach is correct. since nothing
> on that so I hope I am on the correct track. Thanks.
> I will send in the next version in a day or two.
At quick glance, you are on the right track. Writing a new bus is hard,
I know, the documentation is lacking and it's tricky in places and the
api is horrid in others. I know this, just never had the time to make
it easier, so if you have any questions about it, please let me know.
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-11 7:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 14:30 [PATCH WIP] parport: add device model Sudip Mukherjee
2015-04-10 14:49 ` Dan Carpenter
2015-04-11 5:26 ` Sudip Mukherjee
2015-04-11 7:27 ` Greg KH [this message]
2015-04-11 8:11 ` Sudip Mukherjee
2015-04-13 8:27 ` Sudip Mukherjee
2015-04-13 8:43 ` Greg KH
2015-04-13 10:02 ` Sudip Mukherjee
2015-04-13 10:42 ` Greg KH
2015-04-13 10:38 ` Dan Carpenter
2015-04-10 18:24 ` Ondrej Zary
2015-04-11 5:05 ` Sudip Mukherjee
2015-04-11 9:24 ` Ondrej Zary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150411072716.GD10063@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).