From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754973AbbDKNAG (ORCPT ); Sat, 11 Apr 2015 09:00:06 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:34408 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753477AbbDKNAD (ORCPT ); Sat, 11 Apr 2015 09:00:03 -0400 Date: Sat, 11 Apr 2015 18:29:50 +0530 From: Sudip Mukherjee To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: lidza.louina@gmail.com, markh@compro.net, gregkh@linuxfoundation.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2 RESEND] staging: dgnc: remove dead code in dgnc_tty_write() Message-ID: <20150411125950.GA4833@sudip-PC> References: <1428677335-6853-1-git-send-email-giedrius.statkevicius@gmail.com> <20150411045144.GA3496@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 11, 2015 at 03:20:43PM +0300, Giedrius Statkevičius wrote: > On Sat, 11 Apr 2015, Sudip Mukherjee wrote: > > > On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote: > Well, I think this is wrong because: yes. I looked at many of the tty drivers and all of them have used memcpy(). Sorry for my last mail, i should have written that after seeing all other similar drivers and maybe once in a while i should go back to LDD3. :) regards sudip > > Su pagarba / Regards, > Giedrius