Re: [PATCH 0/2] locking: Simplify mutex and rwsem spinning code

Jason Low
2015-04-08T20:10:50Z

On Wed, 2015-04-08 at 12:49 -0700, Davidlohr Bueso wrote:
> On Wed, 2015-04-08 at 12:39 -0700, Jason Low wrote:
> > This patchset applies on top of tip.
> >
> > Jason Low (2):
> > locking/mutex: Further refactor mutex_spin_on_owner()
> > locking/rwsem: Use a return variable in rwsem_spin_on_owner()
> >
> > kernel/locking/mutex.c | 14 ++++----------
> > kernel/locking/rwsem-xadd.c | 25 ++++++++++++-------------
> > 2 files changed, 16 insertions(+), 23 deletions(-)
>
> Meh. Personally I wouldn't mid leaving these files alone for a change,
> the code is already pretty readable imho. Of course its a matter of
> taste, so I won't argue.

I agree that it's quite readable now too, though Peter and Ingo seems
like they would prefer these changes :)