From: Greg KH <greg@kroah.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Arnd Bergmann <arnd@arndb.de>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Tomas Winkler <tomas.winkler@intel.com>
Subject: Re: [PATCH] mei: trace: Remove unused TRACE_SYSTEM_STRING define
Date: Mon, 13 Apr 2015 18:56:19 +0200 [thread overview]
Message-ID: <20150413165619.GB32634@kroah.com> (raw)
In-Reply-To: <20150413120727.3bb82df0@gandalf.local.home>
On Mon, Apr 13, 2015 at 12:07:27PM -0400, Steven Rostedt wrote:
> TRACE_SYSTEM_STRING is defined in mei-trace.h but is unused. Worse yet,
> the ftrace tracing infrastructure is using it now and this causes
> warnings about redefined macros.
>
> Remove the define of TRACE_SYSTEM_STRING from mei-trace.h
>
> Link: http://lkml.kernel.org/r/20150413193720.56083fbf@canb.auug.org.au
>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> diff --git a/drivers/misc/mei/mei-trace.h b/drivers/misc/mei/mei-trace.h
> index 5f4e1a17360b..c9e24d2b698a 100644
> --- a/drivers/misc/mei/mei-trace.h
> +++ b/drivers/misc/mei/mei-trace.h
> @@ -26,7 +26,6 @@
> #undef TRACE_SYSTEM
>
> #define TRACE_SYSTEM mei
> -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM)
>
> TRACE_EVENT(mei_reg_read,
> TP_PROTO(const struct device *dev, const char *reg, u32 offs, u32 val),
This is already in my tree, and will show up in the next linux-next :)
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-13 16:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 9:37 linux-next: build warnings after merge of the char-misc tree Stephen Rothwell
2015-04-13 10:43 ` Greg KH
2015-04-13 10:44 ` Winkler, Tomas
2015-04-13 10:47 ` Stephen Rothwell
2015-04-13 14:17 ` Steven Rostedt
2015-04-13 15:01 ` Steven Rostedt
2015-04-13 16:07 ` [PATCH] mei: trace: Remove unused TRACE_SYSTEM_STRING define Steven Rostedt
2015-04-13 16:56 ` Greg KH [this message]
2015-04-13 13:34 ` linux-next: build warnings after merge of the char-misc tree Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413165619.GB32634@kroah.com \
--to=greg@kroah.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox