From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754846AbbDMVZ7 (ORCPT ); Mon, 13 Apr 2015 17:25:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:58399 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754276AbbDMVZ4 (ORCPT ); Mon, 13 Apr 2015 17:25:56 -0400 Date: Mon, 13 Apr 2015 23:25:52 +0200 From: Greg Kroah-Hartman To: Thomas Gleixner Cc: LKML , Peter Zijlstra , Ingo Molnar , Shigekatsu Tateno , devel@driverdev.osuosl.org Subject: Re: [patch 5/5] staging: ozwpan: Fix hrtimer wreckage Message-ID: <20150413212552.GB2812@kroah.com> References: <20150413210009.682000343@linutronix.de> <20150413210035.357448657@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150413210035.357448657@linutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 13, 2015 at 09:02:25PM -0000, Thomas Gleixner wrote: > oz_timer_add() modifies the expiry value of an active timer, which > results in data corruption. > > Use hrtimer_start() and remove the silly conditional. > > While at it use the proper helper function to convert milliseconds to > ktime. > > Signed-off-by: Thomas Gleixner > Cc: Shigekatsu Tateno > Cc: Greg Kroah-Hartman > Cc: devel@driverdev.osuosl.org > --- > drivers/staging/ozwpan/ozproto.c | 17 ++++------------- > 1 file changed, 4 insertions(+), 13 deletions(-) Acked-by: Greg Kroah-Hartman