From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755210AbbDPR2Q (ORCPT ); Thu, 16 Apr 2015 13:28:16 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:44029 "EHLO e32.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754787AbbDPR1m (ORCPT ); Thu, 16 Apr 2015 13:27:42 -0400 Date: Tue, 14 Apr 2015 11:03:18 -0700 From: Sukadev Bhattiprolu To: Ingo Molnar Cc: Michael Ellerman , mingo@redhat.com, ak@linux.intel.com, Jiri Olsa , Arnaldo Carvalho de Melo , peterz@infradead.org, namhyung@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Pekka Enberg , Arnaldo Carvalho de Melo , Peter Zijlstra , Thomas Gleixner , Linus Torvalds , tom.huynh@freescale.com Subject: Re: 'perf upgrade' (was: Re: [PATCH v9 00/11] Add support for JSON event files.) Message-ID: <20150414180318.GA16873@us.ibm.com> References: <1428993665-2133-1-git-send-email-sukadev@linux.vnet.ibm.com> <20150414085541.GA30202@gmail.com> <1429010508.27414.1.camel@ellerman.id.au> <20150414125822.GA32761@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150414125822.GA32761@gmail.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15041617-0005-0000-0000-00000A233B25 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar [mingo@kernel.org] wrote: Meant to Cc Tom Huynh as they had a related patchset a few months ago. | | * Michael Ellerman wrote: | | > On Tue, 2015-04-14 at 10:55 +0200, Ingo Molnar wrote: | > > * Sukadev Bhattiprolu wrote: | > > | > > > This is another attempt to resurrect Andi Kleen's patchset so users | > > > can specify perf events by their event names rather than raw codes. | > > > | > > > This is a rebase of Andi Kleen's patchset from Jul 30, 2014[1] to 4.0. | > > > (I fixed minor and not so minor conflicts). | > > | > > So this series shows some progress, but instead of this limited | > > checkout ability I'd still prefer it if 'perf download' downloaded | > > the latest perf code itself and built it - it shouldn't be limited | > > to just a small subset of the perf source code! | > | > Ingo, can you please stop blocking this? It's getting ridiculous. | > | > We've been waiting over 8 months for this to go in. | | We just merged a patch series that was first sent in 2013. Some things | take time to get right. I used to rebuild git years ago to work around bugs in rebase, but rarely need to rebuild these days, because it is stable. I am guessing it is the same for most users of perf. IOW, perf download/upgrade can be extended to fetch and build, but dont' understand why that is _required_ to _use_ the JSON files. - perf having an ability to parse JSON files - perf downloading JSON files - perf downloading latest source code - perf downloading dependent RPMS/packages to build (which seem to be tied to distros) all seem like independent steps to me. If current design can be tweaked to not constrain future choices, we should definitely do that. If not, can we make incremental progress on this? If necessary, we could add an option to 'perf upgrade' to fetch only the JSON files? Or by default, 'perf upgrade' can assume --all and download everything it can download. In the future we can add --json-files, --sources etc and still ahve --all fetch everything it can. Sukadev