From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755020AbbDNVC2 (ORCPT ); Tue, 14 Apr 2015 17:02:28 -0400 Received: from imap.thunk.org ([74.207.234.97]:39528 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754069AbbDNVCU (ORCPT ); Tue, 14 Apr 2015 17:02:20 -0400 Date: Tue, 14 Apr 2015 17:02:15 -0400 From: "Theodore Ts'o" To: Al Viro Cc: Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells Subject: Re: linux-next: manual merge of the vfs tree with the ext4 tree Message-ID: <20150414210215.GD29810@thunk.org> Mail-Followup-To: Theodore Ts'o , Al Viro , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, David Howells References: <20150414113025.06905c2a@canb.auug.org.au> <20150414014855.GU889@ZenIV.linux.org.uk> <20150414170000.GB29810@thunk.org> <20150414171743.GC889@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150414171743.GC889@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2015 at 06:17:43PM +0100, Al Viro wrote: > Except that you do not handle the slow unencrypted case - you end up with > kfree() on the freshly kunmaped address. Ah, right, we're actually kmalloc'ing the space that case as well --- so hanging on the cpage is pointless; which was the point you were making. Sorry, I was being slow. So what we have works, but it's not optimal. Will fix. - Ted