From: Peter Zijlstra <peterz@infradead.org>
To: Kan Liang <kan.liang@intel.com>
Cc: acme@kernel.org, eranian@google.com, andi@firstfloor.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/6] perf,core: allow invalid context events to be part of sw/hw groups
Date: Wed, 15 Apr 2015 19:28:56 +0200 [thread overview]
Message-ID: <20150415172856.GA5029@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1429084576-1078-1-git-send-email-kan.liang@intel.com>
On Wed, Apr 15, 2015 at 03:56:11AM -0400, Kan Liang wrote:
> The event count only be read when the event is already
> sched_in.
Yeah, so no. This breaks what groups are. Group events _must_ be
co-scheduled. You cannot guarantee you can schedule events from another
PMU.
Also, I cannot see how this can possibly work, you cannot put these
things on the same event_context.
Also, how does this work wrt cpumasks, regular events are per cpu,
uncore events are per node.
There is so much broken stuff here without explanation its not funny.
Please explain how this does not completely wreck everything?
next prev parent reply other threads:[~2015-04-15 17:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 7:56 [PATCH V2 1/6] perf,core: allow invalid context events to be part of sw/hw groups Kan Liang
2015-04-15 7:56 ` [PATCH V2 2/6] perf evsel: Set evsel->cpus to the evlist->cpus when not constrained Kan Liang
2015-04-15 7:56 ` [PATCH V2 3/6] perf,tools: get real cpu id for print_aggr Kan Liang
2015-04-15 7:56 ` [PATCH V2 4/6] perf,tools: check and re-organize evsel cpu maps Kan Liang
2015-04-16 16:33 ` Mark Rutland
2015-04-15 7:56 ` [PATCH V2 5/6] perf,tools: open/mmap event uses event's cpu map Kan Liang
2015-04-15 7:56 ` [PATCH V2 6/6] perf/x86/intel/uncore: do not implicitly set uncore event cpu Kan Liang
2015-04-16 16:36 ` Mark Rutland
2015-04-15 16:15 ` [PATCH V2 1/6] perf,core: allow invalid context events to be part of sw/hw groups Peter Zijlstra
2015-04-15 16:21 ` Andi Kleen
2015-04-15 16:55 ` Peter Zijlstra
2015-04-15 17:28 ` Peter Zijlstra [this message]
2015-04-16 14:53 ` Liang, Kan
2015-04-16 16:31 ` Mark Rutland
2015-04-16 16:43 ` Mark Rutland
2015-04-16 17:16 ` Mark Rutland
2015-04-16 21:23 ` Andi Kleen
2015-04-17 9:47 ` Mark Rutland
2015-04-18 0:47 ` Andi Kleen
2015-04-20 10:15 ` Mark Rutland
2015-04-20 16:57 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415172856.GA5029@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox