From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754494AbbDOUqz (ORCPT ); Wed, 15 Apr 2015 16:46:55 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:43554 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754486AbbDOUqs (ORCPT ); Wed, 15 Apr 2015 16:46:48 -0400 Date: Wed, 15 Apr 2015 13:46:35 -0700 From: Guenter Roeck To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Ralf Baechle , "David S. Miller" , Network Development , Linux Kernel Mailing List , "linux-mips@linux-mips.org" Subject: Re: [RFC PATCH] bgmac: Fix build error seen if BCM47XX is not configured Message-ID: <20150415204635.GA18364@roeck-us.net> References: <1429128338-28549-1-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Authenticated_sender: guenter@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020203.552ECE37.02D9,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 5 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2015 at 10:21:49PM +0200, Rafał Miłecki wrote: > On 15 April 2015 at 22:05, Guenter Roeck wrote: > > arm:allmodconfig fails to build as follows since ARCH_BCM_5301X > > is configured but not BCM47XX. > > > > drivers/net/ethernet/broadcom/bgmac.c: In function 'bgmac_probe': > > drivers/net/ethernet/broadcom/bgmac.c:1643:2: error: > > implicit declaration of function 'bcm47xx_nvram_getenv' > > > > Fixes: fc300dc3733f ("bgmac: allow enabling on ARCH_BCM_5301X") > > Cc: Rafał Miłecki > > Signed-off-by: Guenter Roeck > > --- > > Seen in today's upstream kernel. > > > > I don't like this fix too much (I think it is quite kludgy), > > so I marked it RFC (and please don't beat the messenger ;-). > > Ooh great, I totally forgot about this :| > > The problem is that fc300dc (bgmac: allow enabling on ARCH_BCM_5301X) > [0] shouldn't really be sent (by me) in the first place. This is > because it depends on 138173d (MIPS: BCM47xx: Move NVRAM header to the > include/linux/.) [1] which isn't in Linus's tree yet. > > So there are two solutions: > 1) Revert fc300dc, wait for 138173d and re-apply fc300dc > 2) Wait for 138173d with this build breakage > > I guess the decisions depends on > a) time needed for David to revert fc300dc & send pull request > vs. > b) time needed for Ralf to send pull request > > David, Ralf, what do you think about this? > Since the fix is in the queue, maybe we can live with the breakage for a few days ? Your solution is definitely _much_ better than my hack. Guenter