From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754639AbbDOWUL (ORCPT ); Wed, 15 Apr 2015 18:20:11 -0400 Received: from one.firstfloor.org ([193.170.194.197]:58296 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751937AbbDOWUI (ORCPT ); Wed, 15 Apr 2015 18:20:08 -0400 Date: Thu, 16 Apr 2015 00:20:06 +0200 From: Andi Kleen To: Mel Gorman Cc: Linux-MM , Rik van Riel , Johannes Weiner , Dave Hansen , Andi Kleen , LKML Subject: Re: [PATCH 2/4] mm: Send a single IPI to TLB flush multiple pages when unmapping Message-ID: <20150415222006.GS2366@two.firstfloor.org> References: <1429094576-5877-1-git-send-email-mgorman@suse.de> <1429094576-5877-3-git-send-email-mgorman@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1429094576-5877-3-git-send-email-mgorman@suse.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I did a quick read and it looks good to me. It's a bit ugly to bloat current with the ubc pointer, but i guess there's no good way around that. Also not nice to use GFP_ATOMIC for the allocation, but again there's no way around it and it will eventually recover if it fails. There may be a slightly better GFP flag for this situation that doesn't dip into the interrupt pools? -Andi -- ak@linux.intel.com -- Speaking for myself only.