From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756048AbbDOWyf (ORCPT ); Wed, 15 Apr 2015 18:54:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:55370 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751300AbbDOWy1 (ORCPT ); Wed, 15 Apr 2015 18:54:27 -0400 Date: Wed, 15 Apr 2015 23:53:54 +0100 From: Mel Gorman To: Andi Kleen Cc: Linux-MM , Rik van Riel , Johannes Weiner , Dave Hansen , LKML Subject: Re: [PATCH 2/4] mm: Send a single IPI to TLB flush multiple pages when unmapping Message-ID: <20150415225354.GK14842@suse.de> References: <1429094576-5877-1-git-send-email-mgorman@suse.de> <1429094576-5877-3-git-send-email-mgorman@suse.de> <20150415222006.GS2366@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20150415222006.GS2366@two.firstfloor.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2015 at 12:20:06AM +0200, Andi Kleen wrote: > > I did a quick read and it looks good to me. > Thanks. Does that also include a guarantee that a write to a clean TLB entry will fault if the underlying PTE is unmapped? > It's a bit ugly to bloat current with the ubc pointer, > but i guess there's no good way around that. > I didn't see a better alternative. > Also not nice to use GFP_ATOMIC for the allocation, > but again there's no way around it and it will > eventually recover if it fails. There may be > a slightly better GFP flag for this situation that > doesn't dip into the interrupt pools? > I can use GFP_KERNEL|__GFP_NOWARN. In the kswapd case, it's early in the lifetime of the system so it's not going to enter direct reclaim. In the direct reclaim path, the allocation will not recurse due to PF_MEMALLOC. It ends up achieving the same effect without being as obvious as GFP_ATOMIC was. -- Mel Gorman SUSE Labs