From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752262AbbDPPfU (ORCPT ); Thu, 16 Apr 2015 11:35:20 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:55437 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbbDPPfR (ORCPT ); Thu, 16 Apr 2015 11:35:17 -0400 Date: Thu, 16 Apr 2015 17:35:03 +0200 From: Peter Zijlstra To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andreas Messerschmid Subject: Re: [PATCH] lockdep: make print_lock_name() robust against non-existing lock_class Message-ID: <20150416153503.GC12676@worktop.ger.corp.intel.com> References: <1429104276-22412-1-git-send-email-bigeasy@linutronix.de> <20150415141440.GQ23123@twins.programming.kicks-ass.net> <552FCC2D.4050304@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <552FCC2D.4050304@linutronix.de> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2015 at 04:50:21PM +0200, Sebastian Andrzej Siewior wrote: > Andreas confirmed that it works for him on v3.18 with minor adjustment. > > <--- > + struct held_lock lock = READ_ONCE(*hlock); > + unsigned int class_idx = lock.class_idx; > ---> > I'm confused by the need for that. What was the failure with the proposed patch?