Re: [PATCH v3] watchdog: add watchdog_cpumask sysctl to assist nohz

Peter Zijlstra
2015-04-02T18:06:49Z

On Thu, Apr 02, 2015 at 01:39:28PM -0400, cmetcalf@ezchip.com wrote:
> @@ -431,6 +434,10 @@ static void watchdog_enable(unsigned int cpu)
> hrtimer_init(hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
> hrtimer->function = watchdog_timer_fn;
>
> + /* Exit if the cpu is not allowed for watchdog. */
> + if (!cpumask_test_cpu(cpu, watchdog_mask))
> + do_exit(0);
> +

Ick, that doesn't look right for smpboot threads.