From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753225AbbDQBlx (ORCPT ); Thu, 16 Apr 2015 21:41:53 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:34835 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751426AbbDQBlo (ORCPT ); Thu, 16 Apr 2015 21:41:44 -0400 Date: Fri, 17 Apr 2015 10:41:37 +0900 From: Minchan Kim To: Sergey Senozhatsky Cc: Sergey Senozhatsky , Andrew Morton , Nitin Gupta , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] zram: enable compaction support in zram Message-ID: <20150417014137.GD28196@blaptop> References: <1429232860-31751-1-git-send-email-sergey.senozhatsky@gmail.com> <20150417013129.GC28196@blaptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 17, 2015 at 10:34:57AM +0900, Sergey Senozhatsky wrote: > >> Commit c72c6160d967 ("zram: move compact_store() to sysfs functions > area") > >> was intended to be a cosmetic change that moved function around w/o any > >> functional change: > >> http://lkml.iu.edu/hypermail/linux/kernel/1503.1/01818.html > >> > >> Unfortunately, on its way from mmotm to Linus's tree it was altered and > turned > >> into "remove compaction support from zram" commit. I've managed to > create a > >> mess of commits and Andrew had to pick some of the commits and hand edit > them. > >> > >> Fix it and learn my lessons. > >> > >> Signed-off-by: Sergey Senozhatsky > > Acked-by: Minchan Kim > > > let's just revert c72c6160d967ed26a0b136dbab337f821d233509 instead. > this commit doesn't make a lot of sense. Agree. -- Kind regards, Minchan Kim