public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: lee.jones@linaro.org
Cc: patches@opensource.wolfsonmicro.com, broonie@kernel.org,
	sameo@linux.intel.com, linux-kernel@vger.kernel.org,
	lgirdwood@gmail.com
Subject: Re: [PATCH 5/9] mfd: wm5110: Add register patch required for low power sleep
Date: Fri, 17 Apr 2015 09:09:37 +0100	[thread overview]
Message-ID: <20150417080937.GB3480@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1428508578-21022-6-git-send-email-ckeepax@opensource.wolfsonmicro.com>

On Wed, Apr 08, 2015 at 04:56:14PM +0100, Charles Keepax wrote:
> Some register settings must be applied before the first time low power
> sleep mode is entered on the wm5110 to ensure optimium performance.
> These settings require SYSCLK to be enabled whilst they are being
> applied. This patch applies the settings using the recently factored out
> boot time SYSCLK functionality.
> 
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/mfd/arizona-core.c |   42 ++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 42 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index f1d9ef0..745ee6c 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -405,6 +405,38 @@ static int wm5102_clear_write_sequencer(struct arizona *arizona)
>  	return 0;
>  }
>  
> +/*
> + * Register patch to some of the CODECs internal write sequences
> + * to ensure a clean exit from the low power sleep state.
> + */
> +static const struct reg_default wm5110_sleep_patch[] = {
> +	{ 0x337A, 0xC100 },
> +	{ 0x337B, 0x0041 },
> +	{ 0x3300, 0xA210 },
> +	{ 0x3301, 0x050C },
> +};
> +
> +static int wm5110_apply_sleep_patch(struct arizona *arizona)
> +{
> +	struct arizona_sysclk_state state;
> +	int err, ret;
> +
> +	ret = arizona_enable_freerun_sysclk(arizona, &state);
> +	if (ret)
> +		return ret;
> +
> +	ret = regmap_multi_reg_write_bypassed(arizona->regmap,
> +					      wm5110_sleep_patch,
> +					      ARRAY_SIZE(wm5110_sleep_patch));
> +
> +	err = arizona_disable_freerun_sysclk(arizona, &state);
> +
> +	if (ret)
> +		return ret;
> +	else
> +		return err;

Sorry this should also be a ternary, will do a new spin.

Thanks,
Charles

  reply	other threads:[~2015-04-17  8:09 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-08 15:56 [PATCH 0/9] wm5110 Boot Fixups Charles Keepax
2015-04-08 15:56 ` [PATCH 1/9] mfd: arizona: Use devres to manage reset GPIO Charles Keepax
2015-04-08 15:56 ` [PATCH 2/9] mfd: arizona: Factor out hard reset into helper functions Charles Keepax
2015-04-08 15:56 ` [PATCH 3/9] mfd: wm5102: Ensure we always boot the device fully Charles Keepax
2015-04-08 15:56 ` [PATCH 4/9] mfd: arizona: Factor out SYSCLK enable from wm5102 hardware patch Charles Keepax
2015-04-08 15:56 ` [PATCH 5/9] mfd: wm5110: Add register patch required for low power sleep Charles Keepax
2015-04-17  8:09   ` Charles Keepax [this message]
2015-04-08 15:56 ` [PATCH 6/9] regulator: arizona-ldo1: Add additional supported voltage Charles Keepax
2015-04-08 15:56 ` [PATCH 7/9] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode Charles Keepax
2015-04-08 15:56 ` [PATCH 8/9] mfd: arizona: Add better support for system suspend Charles Keepax
2015-04-08 15:56 ` [PATCH 9/9] mfd: wm5110: Add delay before releasing reset line Charles Keepax

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150417080937.GB3480@opensource.wolfsonmicro.com \
    --to=ckeepax@opensource.wolfsonmicro.com \
    --cc=broonie@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox