From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Inha Song <ideal.song@samsung.com>
Cc: lee.jones@linaro.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com, cw00.choi@samsung.com,
broonie@kernel.org, rf@opensource.wolfsonmicro.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk
Subject: Re: [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support hpdet channel
Date: Fri, 17 Apr 2015 10:01:56 +0100 [thread overview]
Message-ID: <20150417090156.GD3480@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1429259579-16563-3-git-send-email-ideal.song@samsung.com>
On Fri, Apr 17, 2015 at 05:32:59PM +0900, Inha Song wrote:
> This patch add device tree bindings for the pdata needed to configure
> the Accessory Detect Mode select when Headphone detection.
>
> Signed-off-by: Inha Song <ideal.song@samsung.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 7bd1273..e7cb939 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -49,6 +49,10 @@ Optional properties:
> input singals. If values less than the number of input signals, elements
> that has not been specifed are set to 0 by default.
>
> + - wlf,hpdet-channel : Headphone detection channel, this filed to be used the
> + ACCDET_MODE bits in the ACCESSORY_DETECT_MODE_1 register. The valid values
> + are 0 for HPDETL and 1 for HPDETR.
Lets remove the references to the register bits this tends to add some
confusion to the binding doc review and update to mention the
defines I suggested adding in the other patch.
Thanks,
Charles
> +
> - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
> they are being externally supplied. As covered in
> Documentation/devicetree/bindings/regulator/regulator.txt
> --
> 2.0.0.390.gcb682f8
>
prev parent reply other threads:[~2015-04-17 9:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 8:32 [alsa-devel] [PATCH 0/2] Add support for select accessory detect mode to HPDETL or HPDETR Inha Song
2015-04-17 8:32 ` [alsa-devel] [PATCH 1/2] extcon: arizona: Add support for select accessory detect mode when headphone detection" Inha Song
2015-04-17 9:00 ` Charles Keepax
2015-04-20 1:45 ` Inha Song
2015-04-20 8:29 ` Charles Keepax
2015-04-17 9:30 ` Charles Keepax
2015-04-17 8:32 ` [alsa-devel] [PATCH 2/2] mfd: arizona: Update DT binding to support hpdet channel Inha Song
2015-04-17 9:01 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417090156.GD3480@opensource.wolfsonmicro.com \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=ideal.song@samsung.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pawel.moll@arm.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).