* [PATCH] dmaengine: at_xdmac: unlock spin lock before return
@ 2015-04-07 14:42 Niklas Cassel
2015-04-10 13:49 ` Ludovic Desroches
2015-04-17 18:09 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: Niklas Cassel @ 2015-04-07 14:42 UTC (permalink / raw)
To: vinod.koul; +Cc: ludovic.desroches, dmaengine, linux-kernel, Niklas Cassel
Signed-off-by: Niklas Cassel <niklass@axis.com>
---
drivers/dma/at_xdmac.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
index d9891d3..933e4b3 100644
--- a/drivers/dma/at_xdmac.c
+++ b/drivers/dma/at_xdmac.c
@@ -1154,8 +1154,10 @@ static int at_xdmac_device_resume(struct dma_chan *chan)
dev_dbg(chan2dev(chan), "%s\n", __func__);
spin_lock_bh(&atchan->lock);
- if (!at_xdmac_chan_is_paused(atchan))
+ if (!at_xdmac_chan_is_paused(atchan)) {
+ spin_unlock_bh(&atchan->lock);
return 0;
+ }
at_xdmac_write(atxdmac, AT_XDMAC_GRWR, atchan->mask);
clear_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: at_xdmac: unlock spin lock before return
2015-04-07 14:42 [PATCH] dmaengine: at_xdmac: unlock spin lock before return Niklas Cassel
@ 2015-04-10 13:49 ` Ludovic Desroches
2015-04-17 18:09 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Desroches @ 2015-04-10 13:49 UTC (permalink / raw)
To: Niklas Cassel
Cc: vinod.koul, ludovic.desroches, dmaengine, linux-kernel,
Niklas Cassel
On Tue, Apr 07, 2015 at 04:42:45PM +0200, Niklas Cassel wrote:
> Signed-off-by: Niklas Cassel <niklass@axis.com>
of course
Acked-by: Ludovic Desroches <ludovic.desroches@atmel.com>
Thanks
> ---
> drivers/dma/at_xdmac.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index d9891d3..933e4b3 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1154,8 +1154,10 @@ static int at_xdmac_device_resume(struct dma_chan *chan)
> dev_dbg(chan2dev(chan), "%s\n", __func__);
>
> spin_lock_bh(&atchan->lock);
> - if (!at_xdmac_chan_is_paused(atchan))
> + if (!at_xdmac_chan_is_paused(atchan)) {
> + spin_unlock_bh(&atchan->lock);
> return 0;
> + }
>
> at_xdmac_write(atxdmac, AT_XDMAC_GRWR, atchan->mask);
> clear_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
> --
> 2.1.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dmaengine: at_xdmac: unlock spin lock before return
2015-04-07 14:42 [PATCH] dmaengine: at_xdmac: unlock spin lock before return Niklas Cassel
2015-04-10 13:49 ` Ludovic Desroches
@ 2015-04-17 18:09 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2015-04-17 18:09 UTC (permalink / raw)
To: Niklas Cassel; +Cc: ludovic.desroches, dmaengine, linux-kernel, Niklas Cassel
On Tue, Apr 07, 2015 at 04:42:45PM +0200, Niklas Cassel wrote:
> Signed-off-by: Niklas Cassel <niklass@axis.com>
> ---
> drivers/dma/at_xdmac.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index d9891d3..933e4b3 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1154,8 +1154,10 @@ static int at_xdmac_device_resume(struct dma_chan *chan)
> dev_dbg(chan2dev(chan), "%s\n", __func__);
>
> spin_lock_bh(&atchan->lock);
> - if (!at_xdmac_chan_is_paused(atchan))
> + if (!at_xdmac_chan_is_paused(atchan)) {
> + spin_unlock_bh(&atchan->lock);
> return 0;
> + }
>
> at_xdmac_write(atxdmac, AT_XDMAC_GRWR, atchan->mask);
> clear_bit(AT_XDMAC_CHAN_IS_PAUSED, &atchan->status);
> --
> 2.1.4
>
Applied now
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-17 18:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-07 14:42 [PATCH] dmaengine: at_xdmac: unlock spin lock before return Niklas Cassel
2015-04-10 13:49 ` Ludovic Desroches
2015-04-17 18:09 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox