From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933048AbbDQSVJ (ORCPT ); Fri, 17 Apr 2015 14:21:09 -0400 Received: from mga14.intel.com ([192.55.52.115]:38311 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932250AbbDQSVE (ORCPT ); Fri, 17 Apr 2015 14:21:04 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,596,1422950400"; d="scan'208";a="482324353" Date: Fri, 17 Apr 2015 23:45:42 +0530 From: Vinod Koul To: Arnd Bergmann Cc: Dan Williams , Laurent Pinchart , dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: shdmac: avoid unused variable warnings Message-ID: <20150417181542.GL30624@intel.com> References: <27084610.k92kokiTBY@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <27084610.k92kokiTBY@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 11, 2015 at 12:27:58AM +0200, Arnd Bergmann wrote: > This driver uses '#ifdef CONFIG_ARCH_SHMOBILE' and '#ifdef CONFIG_ARM' > interchangeably in its sh_dmae_probe function, which causes a build > warning when building for ARM without also enabling shmobile: > > dma/sh/shdmac.c: In function sh_dmae_probe: > dma/sh/shdmac.c:696:6: warning: unused variable errirq [-Wunused-variable] > dma/sh/shdmac.c:695:16: warning: unused variable irqflags [-Wunused-variable] > dma/sh/shdmac.c: At top level: > dma/sh/shdmac.c:447:20: warning: sh_dmae_err defined but not used [-Wunused-function] > > This changes all the #ifdef to test for CONFIG_ARCH_SHMOBILE to > avoid that warning. An earlier patch from Laurent had fixed the warning > for non-ARM case, but it still remained present in ARM randconfig builds. > > Signed-off-by: Arnd Bergmann > Fixes: 52d6a5ee101bf ("DMA: shdma: Fix warnings due to declared but unused symbols") Applied, thanks -- ~Vinod